Remove the orm:ensure-production-settings console command (#9263)

doctrine · Dec 18, 2021 · ad97969 · ad97969
1 parent 25ca8dc
commit ad97969
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 190 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -20,6 +20,11 @@ _before_ upgrading to 3.0:
 php doctrine orm:convert-mapping xml /path/to/mapping-path-converted-to-xml
 ```
 
+## BC BREAK: Remove the `orm:ensure-production-settings` console command
+
+The `orm:ensure-production-settings` console command and its implementation
+`Doctrine\ORM\Tools\Console\Command\EnsureProductionSettingsCommand` have been removed.
+
 ## BC BREAK: Remove code generators and related console commands
 
 These console commands have been removed:

diff --git a/docs/en/reference/tools.rst b/docs/en/reference/tools.rst
@@ -77,8 +77,6 @@ The following Commands are currently available:
  cache drivers.
 - ``orm:clear-cache:result`` Clear result cache of the various
  cache drivers.
-- ``orm:ensure-production-settings`` Verify that Doctrine is
- properly configured for a production environment.
 - ``orm:generate-proxies`` Generates proxy classes for entity
  classes.
 - ``orm:run-dql`` Executes arbitrary DQL directly from the command

diff --git a/lib/Doctrine/ORM/Tools/Console/Command/EnsureProductionSettingsCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/EnsureProductionSettingsCommand.php
diff --git a/lib/Doctrine/ORM/Tools/Console/ConsoleRunner.php b/lib/Doctrine/ORM/Tools/Console/ConsoleRunner.php
@@ -92,7 +92,6 @@ public static function addCommands(Application $cli, ?EntityManagerProvider $ent
  new Command\SchemaTool\CreateCommand($entityManagerProvider),
  new Command\SchemaTool\UpdateCommand($entityManagerProvider),
  new Command\SchemaTool\DropCommand($entityManagerProvider),
- new Command\EnsureProductionSettingsCommand($entityManagerProvider),
  new Command\GenerateProxiesCommand($entityManagerProvider),
  new Command\RunDqlCommand($entityManagerProvider),
  new Command\ValidateSchemaCommand($entityManagerProvider),

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -3153,11 +3153,6 @@
  <code>$cacheDriver</code>
  </PossiblyNullArgument>
  </file>
- <file src="lib/Doctrine/ORM/Tools/Console/Command/EnsureProductionSettingsCommand.php">
- <MissingReturnType occurrences="1">
- <code>configure</code>
- </MissingReturnType>
- </file>
  <file src="lib/Doctrine/ORM/Tools/Console/Command/GenerateProxiesCommand.php">
  <DeprecatedMethod occurrences="2">
  <code>getProxyDir</code>

diff --git a/psalm.xml b/psalm.xml
@@ -20,8 +20,6 @@
  <errorLevel type="suppress">
  <!-- The exception is thrown by a deprecated method. -->
  <referencedClass name="Doctrine\ORM\Cache\Exception\InvalidResultCacheDriver"/>
- <!-- Remove on 3.0.x -->
- <referencedClass name="Doctrine\ORM\Tools\Console\Command\EnsureProductionSettingsCommand"/>
  </errorLevel>
  </DeprecatedClass>
  <DeprecatedMethod>

diff --git a/tests/Doctrine/Tests/ORM/Tools/Console/Command/EnsureProductionSettingsCommandTest.php b/tests/Doctrine/Tests/ORM/Tools/Console/Command/EnsureProductionSettingsCommandTest.php
diff --git a/tests/Doctrine/Tests/ORM/Tools/Console/ConsoleRunnerTest.php b/tests/Doctrine/Tests/ORM/Tools/Console/ConsoleRunnerTest.php
@@ -38,7 +38,6 @@ public function testCreateApplicationShouldReturnAnApplicationWithTheCorrectComm
  self::assertTrue($app->has('orm:clear-cache:metadata'));
  self::assertTrue($app->has('orm:clear-cache:query'));
  self::assertTrue($app->has('orm:clear-cache:result'));
- self::assertTrue($app->has('orm:ensure-production-settings'));
  self::assertTrue($app->has('orm:generate-proxies'));
  self::assertTrue($app->has('orm:generate:proxies'));
  self::assertTrue($app->has('orm:info'));