-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDC-3130: [GH-1033] [WIP] Lazy criteria for ManyToMany collection #3908
Labels
Comments
|
Comment created by @doctrinebot: |
Comment created by @doctrinebot: |
1 similar comment
Comment created by @doctrinebot: |
Comment created by @doctrinebot: A related Github Pull-Request [GH-1033] was unlabeled: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira issue originally created by user @doctrinebot:
This issue is created automatically through a Github pull request on behalf of bakura10:
Url: #1033
Message:
This continues my previous work on making Criteria most efficient.
Currently we are wrapping matching calls on repositories and matching calls on EXTRA_LAZY associations around a LazyCriteria. However, ManyToMany are still completely loaded: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/PersistentCollection.php#L874
This is still problematic from a performance point of view because count, contains... cannot be optimized. I think the solution is similar to previous one, hence creating a Lazy collection for that kind of associations.
However, this is really tricky to do because of the whole mess inside the persisters (can't wait for them to be completely refactored, it's getting really hard to maintain this mess :p).
The text was updated successfully, but these errors were encountered: