Lazy criteria for ManyToMany collection #1033
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3130 We use Jira to track the state of pull requests and the versions they got |
|
Just curious: as custom persisters is not supported, how hard would it be to refactor the persisters completely (as there is no problematic of BC in this part of the code then)? |
|
@bakura10 probably not a big deal |
| @@ -254,6 +258,11 @@ public function count(PersistentCollection $coll) | |||
| . ' FROM ' . $joinTableName . ' t' | |||
| . $joinTargetEntitySQL | |||
| . ' WHERE ' . implode(' AND ', $conditions); | |||
| var_dump($joinTargetEntitySQL); | |||
There was a problem hiding this comment.
Sorry some debugging of mine.
Actually I think I'll need to rethink this PR. I think I can actually reuse the various count, slice, exists... method of the persistentCollection. The problem is that because of the additional criteria, I should make those various methods aware of the Criteria...
For now I'll let this as a WIP and try to come up for a solution if I have some time. But really, I think all those part should be rewritten from scratch...
|
Working on this issue... will require some deep Persisters refactoring. |
Ocramius
changed the title
|
Tried to integrate this PR in the existing persisters, and I realized that parameter types are not considered. |
|
Any news on this? |
|
Any news on this? I understand that it looks like an edge case, however it really prevents anyone implementing EXTRA_LAZY associations from really benefitting from them. If no fix is upcoming, can someone maybe explain what the difficulty in implementing this exactly is? |
This continues my previous work on making Criteria most efficient.
Currently we are wrapping matching calls on repositories and matching calls on EXTRA_LAZY associations around a LazyCriteria. However, ManyToMany are still completely loaded: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/PersistentCollection.php#L874
This is still problematic from a performance point of view because count, contains... cannot be optimized. I think the solution is similar to previous one, hence creating a Lazy collection for that kind of associations.
However, this is really tricky to do because of the whole mess inside the persisters (can't wait for them to be completely refactored, it's getting really hard to maintain this mess :p).