Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrayHydration of enums #10041

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

michnovka
Copy link
Contributor

Fix for #10031

@derrabus
Copy link
Member

This had been fixed by #9995 already, but I must admit that I find your solution more elegant.

@greg0ire @beberlei WDYT, shall we revert #9995 and go with this solution instead?

@greg0ire
Copy link
Member

I think we should. @michnovka can you add a revert commit to this PR? After that we should release because 2 fixes for the same bug means it must be quite painful.

@derrabus derrabus added this to the 2.13.2 milestone Sep 22, 2022
@derrabus derrabus merged commit c65ff66 into doctrine:2.13.x Sep 22, 2022
@derrabus
Copy link
Member

I've pushed a revert commit 5f29fcd before merging this one. Thanks @michnovka and @kvush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants