Document properties as possibly null #10089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
remove-unneeded-checks
branch
2 times, most recently
from
364fcff
to
951b3e3
Compare
greg0ire
force-pushed
the
remove-unneeded-checks
branch
from
951b3e3
to
4ade0d0
Compare
greg0ire
force-pushed
the
remove-unneeded-checks
branch
3 times, most recently
from
f139165
to
a3001d7
Compare
greg0ire
requested review from
derrabus and
SenseException
and removed request for
derrabus and
SenseException
This comment was marked as resolved.
This comment was marked as resolved.
__sleep() does not list these properties as suposed to be serialized. This means we have to assert that it is not in the many scenarios where we resort to these properties. Introducing a private method allows us to centralize the assertions.
greg0ire
force-pushed
the
remove-unneeded-checks
branch
from
a3001d7
to
397751e
Compare
SenseException
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__sleep()does not list these properties as suposed to be serialized.This means we have to assert that it is not in the many scenarios where
we resort to these properties. Introducing a private method allows us to
centralize the assertions.