Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automap events in AttachEntityListenersListener #10122

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Oct 11, 2022

Required for doctrine/DoctrineBundle#1560

Currently, the AttachEntityListenersListener::addEntityListener() method requires an eventName to be specified when registering a listener. With this change null can be passed allowing the event names to be read from the listener class by iterating over the method names.

@derrabus derrabus merged commit c828a38 into doctrine:2.14.x Oct 26, 2022
@derrabus
Copy link
Member

Thanks!

derrabus added a commit to derrabus/orm that referenced this pull request Oct 26, 2022
* 2.14.x:
  PHPStan 1.8.11 (doctrine#10182)
  Add isMemberOf and isInstanceOf to Expr helper list (doctrine#10104)
  Migrate more references to annotations (doctrine#10176)
  Fix grammer in working-with-objects (doctrine#10120)
  Automap events in AttachEntityListenersListener (doctrine#10122)
  Adapt use statements to the code (doctrine#10174)
derrabus added a commit to derrabus/orm that referenced this pull request Oct 26, 2022
* 2.14.x:
  PHPStan 1.8.11 (doctrine#10182)
  Add isMemberOf and isInstanceOf to Expr helper list (doctrine#10104)
  Migrate more references to annotations (doctrine#10176)
  Fix grammer in working-with-objects (doctrine#10120)
  Automap events in AttachEntityListenersListener (doctrine#10122)
  Adapt use statements to the code (doctrine#10174)
derrabus added a commit to derrabus/orm that referenced this pull request Oct 26, 2022
* 2.14.x:
  PHPStan 1.8.11 (doctrine#10182)
  Add isMemberOf and isInstanceOf to Expr helper list (doctrine#10104)
  Migrate more references to annotations (doctrine#10176)
  Fix grammer in working-with-objects (doctrine#10120)
  Automap events in AttachEntityListenersListener (doctrine#10122)
  Adapt use statements to the code (doctrine#10174)
@HypeMC HypeMC deleted the automap-events-in-attach-entity-listeners-listener branch October 26, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants