Fix type doc blocks in annotation classes #10145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
types/annotations-backports
branch
from
1063f03
to
fb96b36
Compare
greg0ire
approved these changes
Oct 17, 2022
|
Yeah, or make that an enum. 🤔 |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 17, 2022
* 2.14.x: Modernize documentation code Add CI jobs for SQLite3 driver (doctrine#10141) Fix type doc blocks in annotation classes (doctrine#10145) Fix FieldMapping for generated key (doctrine#10144) Stop triggering static analysis workflows on tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.0, I'd like to flag all public properties of our annotation classes as
readonly. Since we always use them as is they were immutable, this is the reasonable thing to do imho.This PR prepares this change by adding a
@readonlyannotation to all dock blocks. I've also fixed a few other inconsistencies.