-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address dbal deprecations #10153
Address dbal deprecations #10153
Conversation
e682164
to
b05227e
Compare
@morozov the failing test calls the update command, then feeds its output to the DBAL. It seems that it is choking on |
There are two issues with this potentially:
No idea. |
I filed doctrine/dbal#5776 for documentation purposes but it's one of the side effects of doctrine/dbal#4357, so it won't be fixed in the near future. |
Thanks for looking into this! Do you think it will be fixed in the far future? Because I pushed something that should fix the issue until then. @derrabus the fix implies using |
6fbe0cf
to
78185f2
Compare
It can be fixed even in the near future but I don't plan for it at the moment. If anybody is interested in fixing it themselves sooner, I can facilitate the process. |
Blocked by #10162 |
The new method AbstractPlatform::getAlterSchemaSQL() should be preferred when available.
1e090fb
to
f599d5a
Compare
if (! method_exists($schemaDiff, 'toSaveSql')) { | ||
throw GlobalNotSupported::createForDbal4('Using save mode when getting update schema SQL'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like dead code to me. We don't support DBAL 4 on this branch and on the 3.0.x branch, we're going to remove the $saveMode
parameter anyway.
f599d5a
to
104cee9
Compare
This implies deprecating a feature relying on that method.
104cee9
to
7cb96fc
Compare
No description provided.