Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PropertyNotSetInConstructor #10218

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

greg0ire
Copy link
Member

Inside the Query\AST namespace, many classes use public properties that are supposed to be set from outside the class. Let us ignore PropertyNotSetInConstructor for that entire namespace instead of doing it on a case by case basis.

Inside the Query\AST namespace, many classes use public properties that
are supposed to be set from outside the class. Let us ignore
PropertyNotSetInConstructor for that entire namespace instead of doing
it on a case by case basis.
@greg0ire greg0ire marked this pull request as ready for review November 11, 2022 10:33
@derrabus derrabus added this to the 3.0.0 milestone Nov 11, 2022
@derrabus derrabus merged commit 8afb644 into doctrine:2.14.x Nov 11, 2022
@derrabus derrabus modified the milestones: 3.0.0, 2.14.0 Nov 11, 2022
@greg0ire greg0ire deleted the ignore-pnsic-for-ast branch November 11, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants