Widen parameter type

[greg0ire]

This exception is used in two places, one where $generatedMode is clearly a string, and another where typing it as a string will cause a type error, because $generatedMode is supposed to be an int there.

Supposed to be an int:

orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

Lines 1720 to 1728 in 465c02f

	if (isset($mapping['generated'])) {
	if (! in_array($mapping['generated'], [self::GENERATED_NEVER, self::GENERATED_INSERT, self::GENERATED_ALWAYS])) {
	throw MappingException::invalidGeneratedMode($mapping['generated']);
	}
	if ($mapping['generated'] === self::GENERATED_NEVER) {
	unset($mapping['generated']);
	}
	}

Supposed to be a string:

orm/lib/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php

Lines 680 to 682 in 465c02f

	if (! defined('Doctrine\ORM\Mapping\ClassMetadata::GENERATED_' . $generatedMode)) {
	throw MappingException::invalidGeneratedMode($generatedMode);
	}

@mehldau this was introduced in #9118, please review

[SenseException]

orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

Line 1656 in 465c02f

* @psalm-param array<string, mixed> $mapping The field mapping to validate & complete.

Isn't this supposed to be array<string, FieldMapping> or did I miss something? Maybe that's why the int could be removed without PHPStan complaining in the PR?

[greg0ire]

There is this comment that suggests FieldMapping should be used more widely, so maybe yeah

EDIT: also, you mean FieldMapping, not array<string, FieldMapping> 😉

[greg0ire]

@SenseException I tried your suggestion, and no, that's not right, because then you get

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1669   Offset 'fieldName' on array{type: string, fieldName: string, columnName: string, length?: int, id?: bool, nullable?: bool, notInsertable?: bool, notUpdatable?: bool, ...} in isset() always exists and is not nullable.

At that point, the mapping is supposed to be incomplete.

[SenseException]

Then let's keep it the way it is.