Make use statements redundant #10256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 68bc00b, while fixing coding style, I introduced many, many use statements in that file. Using half-qualified names sometimes, and unqualified names some other times makes no sense. If AST\ is used at least once, use it always.
greg0ire
force-pushed
the
parser-consistent-style
branch
from
198f0ed
to
5433684
Compare
SenseException
approved these changes
Nov 27, 2022
|
I find it's a bit much, but also, since this was the original style, I elected to pick that one to eliminate the inconsistency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 68bc00b, while fixing coding style, I introduced many, many use statements in that file. Using half-qualified names sometimes, and unqualified names some other times makes no sense.
If
AST\is used at least once, use it always.