Improving formatting of Identifier Generation Strategies

[ThomasLandauer]

• Removing duplications
• Improving scanability (which database uses which field type)

[SenseException]

Thank you for your changes @ThomasLandauer. Can you please add a description what exactly you accomplish with your changes?

[ThomasLandauer]

Sure, done :-)

[greg0ire]

Looks like this is no longer true since #8870 : AbstractPlatform::prefers* methods have been removed. It's now more based on what the platforms supports:

orm/lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php

Lines 727 to 745 in da9b9de

	private function determineIdGeneratorStrategy(AbstractPlatform $platform): int
	{
	if (
	$platform instanceof Platforms\OraclePlatform
	|| $platform instanceof Platforms\PostgreSQLPlatform
	) {
	return ClassMetadata::GENERATOR_TYPE_SEQUENCE;
	}
	if ($platform->supportsIdentityColumns()) {
	return ClassMetadata::GENERATOR_TYPE_IDENTITY;
	}
	if ($platform->supportsSequences()) {
	return ClassMetadata::GENERATOR_TYPE_SEQUENCE;
	}
	throw CannotGenerateIds::withPlatform($platform);
	}

[greg0ire]

Related: #8931

[ThomasLandauer]

OK, then I'm closing this. Just wanted to do some minor formatting improvements - your PR is more important!

[greg0ire]

Well it's been opened for 2 years, and I'm not sure when I'm going to look into it again. I wasn't suggesting you close this, just that you reword slightly this to avoid saying the platform prefers anything.

[ThomasLandauer]

I wasn't suggesting you close this,

I know. But if there's some change ahead, I'd rather wait for the outcome. The current text is not that bad that it's urgent in any way...