Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single table inheritance with intermediate abstract class(es) #10643

Merged
merged 1 commit into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/Doctrine/ORM/Persisters/Entity/SingleTablePersister.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
use Doctrine\ORM\Utility\PersisterHelper;

use function array_flip;
use function array_intersect;
use function array_map;
use function array_unshift;
use function implode;

/**
Expand Down Expand Up @@ -145,16 +148,13 @@ protected function getSelectConditionCriteriaSQL(Criteria $criteria)
/** @return string */
protected function getSelectConditionDiscriminatorValueSQL()
{
$values = [];
$values = array_map(
[$this->conn, 'quote'],
array_flip(array_intersect($this->class->discriminatorMap, $this->class->subClasses))
);

if ($this->class->discriminatorValue !== null) { // discriminators can be 0
$values[] = $this->conn->quote($this->class->discriminatorValue);
}

$discrValues = array_flip($this->class->discriminatorMap);

foreach ($this->class->subClasses as $subclassName) {
$values[] = $this->conn->quote($discrValues[$subclassName]);
array_unshift($values, $this->conn->quote($this->class->discriminatorValue));
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A different approach would be extending of ClassMetadata(Info) with something in the lines of discriminatorSubClasses. This would cause more work and refactoring, though.


$discColumnName = $this->class->getDiscriminatorColumn()['name'];
Expand Down
83 changes: 83 additions & 0 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/GH10625Test.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\Mapping as ORM;
use Doctrine\Tests\OrmFunctionalTestCase;

/**
* @group GH-10625
*/
class GH10625Test extends OrmFunctionalTestCase
{
protected function setUp(): void
{
parent::setUp();

$this->createSchemaForModels(
GH10625Root::class,
GH10625Middle::class,
GH10625Leaf::class
);
}

/**
* @dataProvider queryClasses
*/
public function testLoadFieldsFromAllClassesInHierarchy(string $queryClass): void
{
$entity = new GH10625Leaf();

$this->_em->persist($entity);
$this->_em->flush();
$this->_em->clear();

$loadedEntity = $this->_em->find($queryClass, $entity->id);

self::assertNotNull($loadedEntity);
self::assertInstanceOf(GH10625Leaf::class, $loadedEntity);
}

public static function queryClasses(): array
{
return [
'query via root entity' => [GH10625Root::class],
'query via intermediate entity' => [GH10625Middle::class],
'query via leaf entity' => [GH10625Leaf::class],
];
}
}

/**
* @ORM\Entity
* @ORM\InheritanceType("SINGLE_TABLE")
* @ORM\DiscriminatorMap({ "1": "GH10625Leaf"})
* ^- This DiscriminatorMap contains the single non-abstract Entity class only
*/
abstract class GH10625Root
{
/**
* @ORM\Id
* @ORM\GeneratedValue(strategy="AUTO")
* @ORM\Column(type="integer")
*
* @var int
*/
public $id;
}

/**
* @ORM\Entity
*/
abstract class GH10625Middle extends GH10625Root
{
}

/**
* @ORM\Entity
*/
class GH10625Leaf extends GH10625Middle
{
}