-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix single table inheritance with intermediate abstract class(es) #10643
Merged
greg0ire
merged 1 commit into
doctrine:2.14.x
from
htto:bugfix/sti-with-abstract-intermediate
May 24, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
tests/Doctrine/Tests/ORM/Functional/Ticket/GH10625Test.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
namespace Doctrine\Tests\ORM\Functional\Ticket; | ||
|
||
use Doctrine\ORM\Mapping as ORM; | ||
use Doctrine\Tests\OrmFunctionalTestCase; | ||
|
||
/** | ||
* @group GH-10625 | ||
*/ | ||
class GH10625Test extends OrmFunctionalTestCase | ||
{ | ||
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
|
||
$this->createSchemaForModels( | ||
GH10625Root::class, | ||
GH10625Middle::class, | ||
GH10625Leaf::class | ||
); | ||
} | ||
|
||
/** | ||
* @dataProvider queryClasses | ||
*/ | ||
public function testLoadFieldsFromAllClassesInHierarchy(string $queryClass): void | ||
{ | ||
$entity = new GH10625Leaf(); | ||
|
||
$this->_em->persist($entity); | ||
$this->_em->flush(); | ||
$this->_em->clear(); | ||
|
||
$loadedEntity = $this->_em->find($queryClass, $entity->id); | ||
|
||
self::assertNotNull($loadedEntity); | ||
self::assertInstanceOf(GH10625Leaf::class, $loadedEntity); | ||
} | ||
|
||
public static function queryClasses(): array | ||
{ | ||
return [ | ||
'query via root entity' => [GH10625Root::class], | ||
'query via intermediate entity' => [GH10625Middle::class], | ||
'query via leaf entity' => [GH10625Leaf::class], | ||
]; | ||
} | ||
} | ||
|
||
/** | ||
* @ORM\Entity | ||
* @ORM\InheritanceType("SINGLE_TABLE") | ||
* @ORM\DiscriminatorMap({ "1": "GH10625Leaf"}) | ||
* ^- This DiscriminatorMap contains the single non-abstract Entity class only | ||
*/ | ||
abstract class GH10625Root | ||
{ | ||
/** | ||
* @ORM\Id | ||
* @ORM\GeneratedValue(strategy="AUTO") | ||
* @ORM\Column(type="integer") | ||
* | ||
* @var int | ||
*/ | ||
public $id; | ||
} | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
abstract class GH10625Middle extends GH10625Root | ||
{ | ||
} | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
class GH10625Leaf extends GH10625Middle | ||
{ | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A different approach would be extending of ClassMetadata(Info) with something in the lines of
discriminatorSubClasses
. This would cause more work and refactoring, though.