Copy Debug class from doctrine/common #11000
Conversation
greg0ire
force-pushed
the
copy-debug
branch
3 times, most recently
from
62c1203 to
d15fbed
Compare
| * | ||
| * @dataProvider provideAttributesCases | ||
| * | ||
| * @requires PHP < 8.1.0 |
There was a problem hiding this comment.
Apparently, the representation differs. I can make the data provider output different orders based on the PHP version so that we continue testing this on 3.0
There was a problem hiding this comment.
Do the representations only differ in the order of the array keys? I think PHP 8 changed the order in which parent and child properties are dumped.
If that's the case, let's put the PHP 8.1 representation into the data provider and if we're on PHP 7, we ksort() both arrays before comparing them.
There was a problem hiding this comment.
Yes, that's the only difference. I'll try what you are recommending.
There was a problem hiding this comment.
ksort does not do the trick the order seems to be alphabetical, then public, protected, private :P: https://github.com/doctrine/orm/actions/runs/6500148405/job/17654937509?pr=11000#step:5:89
There was a problem hiding this comment.
Alternatively, if we don't care, I could use https://docs.phpunit.de/en/10.4/assertions.html#assertequalscanonicalizing
There was a problem hiding this comment.
Actually that won't work: we're comparing strings (generated by print_r) here, not arrays. Besides, on 3.0.x, this canonicalization will be useless. As it stands, the code makes it more clear that something can be removed.
greg0ire
force-pushed
the
copy-debug
branch
3 times, most recently
from
190df5f to
63ce659
Compare
This reduces our dependency to this shared library that now holds very little code we use. The class has not been copied verbatim: - Unused parameters and methods have been removed. - The class is final and internal. - Coding standards have been enforced, including enabling strict_types, which lead to casting a variable to string before feeding it to explode(). - A bug found by static analysis has been addressed, where an INI setting obtained with ini_get() was compared with true, which is never returned by that function. - Tests are improved to run on all PHP versions
This is an alternative to 4c8934f (the other commit in the associated PR still stands).
This reduces our dependency to this shared library that now holds very little code we use.
The class has not been copied verbatim:
strict_types, which lead to casting a variable to string before feeding it toexplode().ini_get()was compared with true, which is never returned by that function.A follow-up of this PR could be to leverage Symfony's VarDumper component when available.