Recommend SEQUENCE until doctrine/dbal 4 is released #11044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
previously approved these changes
Nov 5, 2023
greg0ire
force-pushed
the
identity-on-dbal4
branch
from
42af1ff
to
be1614a
Compare
greg0ire
force-pushed
the
identity-on-dbal4
branch
2 times, most recently
from
bc4fab9
to
8881c6b
Compare
Using IDENTITY with doctrine/dbal 3 results in SERIAL, which is not recommended.
greg0ire
force-pushed
the
identity-on-dbal4
branch
from
8881c6b
to
300cffb
Compare
SenseException
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
IDENTITYwithdoctrine/dbal3 results inSERIAL, which is not recommended.On 3.0.x, we should make a different recommendation based on the version of
doctrine/dbalCompanion PR: #11045