Join column index names #1138
Closed
Join column index names #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3310 We use Jira to track the state of pull requests and the versions they got |
| */ | ||
| protected $maker; | ||
|
|
||
| public function getId() |
There was a problem hiding this comment.
Please remove any code not related with the test
There was a problem hiding this comment.
Do you mean the getter/setters?
|
This may have been fixed by doctrine/dbal#769, please re-check. |
|
Just checked one of my projects and my alters list is significantly smaller after updating dbal. Cursory glance I don't see any previously generated indexes being dropped and created in the alters either. Thanks! |
|
Thanks for checking, @stanlemon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ocramius recommended I open this up to discuss the issue I am seeing.
I am trying to explicitly name the index on a column which is used in a join. I've attempted to add two functional tests in this PR to demonstrate what I am seeing. Please forgive me if these tests are not correctly, this is the first time I've attempted to submit a PR like this.
There are two situations I am encountering...
First, I explicitly name the index in the
@Tableannotation on the column used in the join - but the SQL generated fromSchemaToolappears to be a random hash.Second, when I have an existing database table with an existing index and it's named properly (in this example, idx_maker_id) and then I run
SchemaTool->updateSchema()it drops the index with the proper name and creates a new randomly hashed name.Is there a different way of accomplishing what I am trying to do here, or is this a bug?
Thanks for your help and assistance!