Consider usage of setFetchMode when checking for simultaneous usage of fetch-mode EAGER and WITH condition #11445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this get a little more attention? |
aprat84
changed the title
aprat84
changed the title
|
Bumping since this is a big deal |
greg0ire
previously approved these changes
May 23, 2024
SenseException
previously approved these changes
May 23, 2024
greg0ire
dismissed stale reviews from SenseException and themself
The base branch was changed.
|
Retargeting since this is a bugfix. |
…f fetch-mode EAGER and WITH condition. This fixes a bug that arises when an entity relation is mapped with fetch-mode EAGER but setFetchMode LAZY (or anything that is not EAGER) has been used on the query. If the query use WITH condition, an exception is incorrectly raised (Associations with fetch-mode=EAGER may not be using WITH conditions). Fixes doctrine#11128 Co-Authored-By: Albert Prat <albert.prat@interactiu.cat>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11128.
Copy of #11174, author can't complete it right now.
Should be merged up to v3.1