Allow named Arguments to be passed to Dto

[eltharin]

Allow to change argument order or use variadic argument in dto constructor.

When Dto implements (empty) interface WithNamedArguments, ObjectHydrator will pass an associated key<>value argument to Dto constructor.
Dto can use named arguments or a variadic argument to put values in their properties.

Final Goal (to do after) is to allow select NEW ItemDto(item.*) FROM App\Entity\Item as item

updated with with the nested New operator PR.

[greg0ire]

Here you mentioned named arguments and variadic arguments. Is it necessary to add the NAMED keyword to use variadic arguments?

[eltharin]

variadic argument can be used without named keyword but the array will be "indexed" while with namedit will be associated

[greg0ire]

@derrabus please give this another review.

[eltharin]

waiting for #11619 to push EBNF update

[beberlei]

I would prefer if we have only this syntax available CustomerDTO(name: c.name, value: CONCAT(a.city, ' ' , a.zip)) and not the two above that implicitly map the name or the AS naming.

This would in my opinion also make the NAMED keyword obsolete, which I would like to get rid of as well.

The goal should be that named arguments syntax looks exactly the same as in PHP itself, because the NEW className somewhat implies that this is what DQL supports.

[eltharin]

Disable implicity map means that we have to write all the field's names for our queries, instead of add a keyword "named".

Remove AS keyword means for those who actually have a named array as result (with AS keyword) to rewrite all the names while in my case just have to add NEW NAMED myDTO(...) and it's done.

Forcing to write: name: c.name, lastname: c.lastname, age: c.age, birthdate: c.birthdate, ... is in my opinion a waste of time for the few fields to rename.

For those as me who have helpers to select fields to add in queries, remove NAMED keyword means to be obliged to name ALL the fields.

As I said in descritpion, final goal is to be able to write c.* and have all the fields by the names,

That's why the first version of this PR have only AS keyword and not the 'PHP syntax'

[beberlei]

@eltharin I discussed with @greg0ire and @derrabus at our Doctrine core team meetup in person, and I guess the main thing is that we want to avoid adding 2 syntaxes (implicit and AS naming, plus name double colon). We considered both and your arguments and then we would rather remove the PHP-style named arguments syntax and only keep the examples 1+2, so the following should be allowed:

• SELECT NEW NAMED CustomerDTO(a.city, c.name) FROM Customer c JOIN c.address a')
• SELECT NEW NAMED CustomerDTO(c.name, CONCAT(a.city, ' ' , a.zip) AS value) FROM Customer c JOIN c.address a

and this syntax should be removed again:

• SELECT NEW NAMED CustomerDTO(name: c.name, value: CONCAT(a.city, ' ' , a.zip)) FROM Customer c JOIN c.address a

Everything else is 👍 from me.

[eltharin]

thank you to all three of you (and other mainteners) for being so open-minded and for your work.

review has been addressed

[greg0ire]

Thanks @eltharin !

[beberlei]

@eltharin 💯 thanks