Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare PHP 8.4 support: Prevent property hooks from being used #11628

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Oct 8, 2024

Property hooks must be explicitly supported by new code, due to them having to use setRawValue/getRawValue to access the right representation for storing in the database.

For now we prevent property hooks from being used at all so that users will not run into potential BC breaks once property hooks support ships.

Related:

…n external non-raw values without explicit code.
@beberlei beberlei requested a review from greg0ire October 8, 2024 13:25
@beberlei beberlei mentioned this pull request Oct 8, 2024
6 tasks
@greg0ire greg0ire added this to the 2.20.0 milestone Oct 9, 2024
@greg0ire greg0ire merged commit 0e48b19 into 2.20.x Oct 9, 2024
58 checks passed
@greg0ire greg0ire deleted the GH-11624-PreventPropertyHooks branch October 9, 2024 08:36
derrabus added a commit to derrabus/orm that referenced this pull request Oct 9, 2024
* 2.20.x:
  Stop recommending vendor-prefixed PHPDoc (doctrine#11640)
  Let PHPStan detect deprecated usages (doctrine#11639)
  Add upgrade note about property hooks (doctrine#11636)
  Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628)
  Use E_ALL instead of E_ALL | E_STRICT
  Add CI job for PHP 8.4
  fix generating duplicate method stubs
derrabus added a commit to derrabus/orm that referenced this pull request Oct 9, 2024
* 2.20.x:
  Stop recommending vendor-prefixed PHPDoc (doctrine#11640)
  Let PHPStan detect deprecated usages (doctrine#11639)
  Add upgrade note about property hooks (doctrine#11636)
  Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628)
  Use E_ALL instead of E_ALL | E_STRICT
  Add CI job for PHP 8.4
  fix generating duplicate method stubs
derrabus added a commit to derrabus/orm that referenced this pull request Oct 9, 2024
* 2.20.x:
  Stop recommending vendor-prefixed PHPDoc (doctrine#11640)
  Let PHPStan detect deprecated usages (doctrine#11639)
  Add upgrade note about property hooks (doctrine#11636)
  Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628)
  Use E_ALL instead of E_ALL | E_STRICT
  Add CI job for PHP 8.4
  fix generating duplicate method stubs
derrabus added a commit to derrabus/orm that referenced this pull request Oct 9, 2024
* 3.3.x:
  Stop recommending vendor-prefixed PHPDoc (doctrine#11640)
  Let PHPStan detect deprecated usages (doctrine#11639)
  PHPStan 1.12.6 (doctrine#11635)
  Add upgrade note about property hooks (doctrine#11636)
  Prepare PHP 8.4 support: Prevent property hooks from being used (doctrine#11628)
  Use E_ALL instead of E_ALL | E_STRICT
  Add CI job for PHP 8.4
  fix generating duplicate method stubs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants