Updated setParameters function for not replace all parameters

[uthopiko]

When you create QueryBuilder and you bind some parameters, if you use setParameters function after bind other parameters, previous parameters are removed(https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/QueryBuilder.php#L558). This would not be a problem if it was the same behaviour with the attribute $_parameterMappings (in ParserResult), but it's not the case, given that it keeps the number of parameters introduced, throwing an exception(https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query.php#L293). To prevent this, I've made it initialize the setParameters with the existing ones.

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3454

We use Jira to track the state of pull requests and the versions they got
included in.

[Ocramius]

setParameters is supposed to clear previously existing parameters...

[uthopiko]

Yes, but if you do setParameters after call setParameter or another setParameters, clears existing parameters, but not $_parameterMappings and throws exception

[stof]

This change is a BC break. And a BC break in a BC layer is strictly forbidden (the goal of the BC layer is to emulate the old API, otherwise it is useless)

[guilhermeblanco]

I somehow understand why you have parameter count discrepancies, but that's a potential flaw in your code.
The only situation I can imagine is when consuming a DQL providing an IN with an array parameter. When being parsed, this IN becomes N bindable parameters, but your setParameters() call may alter this number.
To solve this, you need to call getQuery() again after you do your new setParameters().

Closing this issue, because your proposed solution is a BC break and cannot be done.