[DDC-3346] #1277 find one with eager loads is failing #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3534 We use Jira to track the state of pull requests and the versions they got |
|
I'l try to see what can I do this weekend |
| $this->assertCount(2, $authors[0]->articles); | ||
| } | ||
|
|
||
| public function testFindWithEagerFetchAndOffsetWillNotHydrateLimitedCollection() |
There was a problem hiding this comment.
This test will fail due to a DBAL bug
|
This bug does not affect 2.4.x, as the eager loading does not work with |
…ly created `CachedPersisterContext`
…e newly created `CachedPersisterContext`
…y created `CachedPersisterContext`
…wly created `CachedPersisterContext`
…wly created `CachedPersisterContext`
…ime, depending on choices
…en limiting and fetch-joining to-many eager associations
…ET repository API (must not hydrate collections)
…Up/tearDown of model-related tables)
…sting more than 1 row
…ling (better to just use private props)
Ocramius
force-pushed
the
hotfix/#1277-find-one-with-eager-loads-is-failing
branch
from
85c23e2
to
97ea6a7
Compare
Ocramius
added a commit
that referenced
this pull request
Jan 25, 2015
…er-loads-is-failing [DDC-3346] #1277 find one with eager loads is failing
Ocramius
deleted the
hotfix/#1277-find-one-with-eager-loads-is-failing
branch
|
@Ocramius the limit = null & offset = 0 is creating a query with just OFFSET and that is raising an error on PHP 5.6.5 (bundled libsqlite was updated to 3.8.7.2). |
|
@lcobucci this should be already fixed here |
|
My mistake, sorry =) |
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @scaytrase
Note that this is a first revision and needs refactoring, so please consider helping out with that if you can.
Ping @guilhermeblanco: please check the
CachedPersisterContextstuff: it's dirty as heck, but that's because the persister internal generated SQL caching is inconsistent as heck too.Resolution path for 2.4.x will be to throw an exception if there is an offset or a limit.