Improve test suite #1289
Merged
Improve test suite #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3546 We use Jira to track the state of pull requests and the versions they got |
| $GLOBALS['db_password'], | ||
| $GLOBALS['db_host'], | ||
| $GLOBALS['db_name'], | ||
| $GLOBALS['db_port'] |
There was a problem hiding this comment.
Thank you, copy-paste :D Will fix.
|
|
|
@deeky666 Great job! |
|
You're welcome. Actually I forgot to bake in doctrine/dbal#779 (doh!). Will do now |
deeky666
force-pushed
the
improve-testsuite
branch
from
dff4e54 to
3b61d2d
Compare
|
okay now it's finished! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts DBAL's latest test suite improvements from doctrine/dbal#597, doctrine/dbal#643, doctrine/dbal#779 and doctrine/dbal#758
Supersedes #1285