Mark getSelectConditionStatementColumnSQL method as private #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3549 We use Jira to track the state of pull requests and the versions they got |
| @@ -106,6 +106,10 @@ or any public API on instantiated objects. | |||
| Please implement the `Doctrine\ORM\Repository\RepositoryFactory` interface instead of extending | |||
| the `Doctrine\ORM\Repository\DefaultRepositoryFactory`. | |||
|
|
|||
| ## BC BREAK: `Doctrine/\ORM\Persisters\BasicEntityPersister::getSelectConditionStatementColumnSQL` has been merked as `private` | |||
|
|
|||
| The `getSelectConditionStatementColumnSQL` has been removed (marked as `private`) from the API. | |||
There was a problem hiding this comment.
Doesn't need to be documented, IMO. Persisters are internal API
There was a problem hiding this comment.
We discussed here about this. If it is not required i can remove this.
There was a problem hiding this comment.
Fair enough, though the persisters really changed radically (even their namespace) :|
goetas
force-pushed
the
private-method-mark
branch
from
d9f74fb
to
fb5cd92
Compare
|
Done. Does I have to test something? |
|
Nope, looks good :-) |
guilhermeblanco
added a commit
that referenced
this pull request
Jan 29, 2015
Mark getSelectConditionStatementColumnSQL method as private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Doctrine/\ORM\Persisters\BasicEntityPersister::getSelectConditionStatementColumnSQLmethod has been marked asprivate.The current
protectedmark is a bit unuseful since everything is already handled into the public methodgetSelectConditionStatementSQL.