[2.4] #1169 DDC-3343 one-to-omany persister deletes only on EXTRA_LAZY plus orphanRemoval #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges should be no-op unless orphan removal is specified.
…anges should be no-op unless orphan removal is specified.
…y + one-to-many element removal behavior
… (failing tests)
…nexisting properties, inexisting owning side assigned
…with the data when `orphanRemoval` and `EXTRA_LAZY` are combined
…picking conflicts
…hey are orphaned and EXTRA_LAZY is used
|
Hello, thank you for creating this pull request. However did not open it on the "master" Please open the pull request again for the "master" branch and close Nevertheless I have opened a Jira ticket for this Pull Request to track this http://www.doctrine-project.org/jira/browse/DDC-3560 We use Jira to track the state of pull requests and the versions they got |
…tity persister to perform deletes on the owning side
…c (sorting deletes by FK dependencies)
|
No complaints, therefore merging. |
Ocramius
added a commit
that referenced
this pull request
Feb 16, 2015
…any-persister-deletes-only-on-extra-lazy-plus-orphan-removal-2.4 [2.4] #1169 DDC-3343 one-to-omany persister deletes only on EXTRA_LAZY plus orphanRemoval
Ocramius
deleted the
hotfix/#1169-DDC-3343-one-to-many-persister-deletes-only-on-extra-lazy-plus-orphan-removal-2.4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1169 and DDC-3343 ( http://www.doctrine-project.org/jira/browse/DDC-3343 ),
EXTRA_LAZYPersistentCollection#removeElement()calls should only affect the database iforphanRemoval=trueis specified in the mappings.Otherwise, being the
one-to-manythe inverse side, no action should be performed.