Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaTool ignoring 'fixed' option #509

Merged
merged 1 commit into from
Nov 7, 2012
Merged

Conversation

smottt
Copy link
Contributor

@smottt smottt commented Nov 7, 2012

If the column is set to fixed string length like this:

<?php

/**
 * @ORM\Column(type="string", length=2, options={"fixed" = true})
 */
protected $foo;

The schema tool will not detect that 'fixed' option correctly when generating update SQL.

Fix attached.

@doctrinebot
Copy link

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DDC-2132

guilhermeblanco added a commit that referenced this pull request Nov 7, 2012
SchemaTool ignoring 'fixed' option
@guilhermeblanco guilhermeblanco merged commit 182ed07 into doctrine:master Nov 7, 2012
@stof
Copy link
Member

stof commented Nov 7, 2012

Trailing whitespaces should be removed and a test should be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants