Allow arithmetic expressions within IN operator

[astepin]

In some cases it is necessary to use not only scalar values or subselects within IN-conditions, but also own functions.

With Oracle databases, the following is then possible:

DQL:
SELECT u FROM User WHERE u.name IN ( CUSTOM_DQL_FUNCTION() );

SQL:
SELECT * FROM user WHERE name IN ( SELECT * FROM TABLE(ORACLE_PLSQL_FUNCTION()) );

Another example which is also possible now:

DQL:
[...] WHERE field IN ( CUSTOM_DQL_GET_ID('Foo'), CUSTOM_ESCAPE('Bar') )

SQL:
[...] WHERE field IN ( (SELECT id FROM settings WHERE name = 'Foo'), [...] )

[Ocramius]

The idea sounds sane, but how does it behave with the "modify limit" logic in the paginator?

[astepin]

As far as i know, does the limit clause not affect any where conditions at all. I don't see any conflicts for the pagination.

The base branch was changed.

[greg0ire]

As PHPStan pointed out, This line needs to be updated

[webda2l]

@astepin You asked how continue this PR #6476 (comment), there is an awaited commit fix here if you want.
See https://github.com/doctrine/orm/pull/6476/checks?check_run_id=3806327129#step:6:30.

Error: Method Doctrine\ORM\Query\Parser::InParameter() should return Doctrine\ORM\Query\AST\InputParameter|Doctrine\ORM\Query\AST\Literal but returns Doctrine\ORM\Query\AST\ArithmeticExpression.

so, @return AST\ArithmeticExpression

[greg0ire]

Why are you using strings in this example? It does not make a lot of sense to use an arithmetic function on a string, does it? Can you maybe write something closer to the real-world use-case you have?

[greg0ire]

You can disregard my comment if that's too hard: I just read the EBNF for https://www.doctrine-project.org/projects/doctrine-orm/en/2.9/reference/dql-doctrine-query-language.html#arithmetic-expressions and now I understand it's not just about 2+2 🙂

[astepin]

In my use case, the scenario looks like this: I have a database platform specific function that I want to use like NVL2 from Oracle. For this I have created a user defined function for DQL in Doctrine and now I want to use this also for IN where conditions.

[greg0ire]

OK. To me it's kind of weird that ArithmeticPrimary contains that many things, for instance FunctionsReturningStrings. I don't think this has much to do with arithmetic, but anyway, that's not really your issue.

[beberlei]

You could also add an arithmetic expression, it should not work before to do IN (1+1)

[webda2l]

@astepin so you have time to update this PR (see #6476 (comment)) or I do another PR ? Thanks

[astepin]

@astepin so you have time to update this PR (see #6476 (comment)) or I do another PR ? Thanks

Hey @webda2l, I will not be able to finish it this year. If you want to take it over, it's okay with me.

[derrabus]

Closing in favor of #9242.