Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace based command names #673

Merged
merged 3 commits into from
May 26, 2013
Merged

Namespace based command names #673

merged 3 commits into from
May 26, 2013

Conversation

nkt
Copy link

@nkt nkt commented May 17, 2013

Symfony console supports auto completion:
orm:generate:entities could called o:g:e

@Ocramius
Copy link
Member

This is a bc break with no real advantage

@Ocramius Ocramius closed this May 17, 2013
@beberlei
Copy link
Member

@hell0w0rd If you add this as alias commands, we could add this, but not this way.

@nkt
Copy link
Author

nkt commented May 17, 2013

@beberlei you read my mind

@Ocramius
Copy link
Member

Didn't think of aliases - that would be indeed very useful =)

@nkt
Copy link
Author

nkt commented May 17, 2013

@Ocramius i fix it, please open PR

@Ocramius Ocramius reopened this May 17, 2013
@nkt
Copy link
Author

nkt commented May 17, 2013

@Ocramius I need fix docs?

@Ocramius
Copy link
Member

@hell0w0rd are aliases actually shown in the command list? Because changing the docs when all commands are still the old ones would be confusing.

@nkt
Copy link
Author

nkt commented May 17, 2013

@Ocramius Yes, all aliases are shown.
For example symfony has two two variants of generate commands:
doctrine:generate:* and generate:doctrine:*, and there are shown at different scopes

doctrine:
doctrine:generate:entities
doctrine:generate:entity
...
generate:
generate:bundle
generate:doctrine:entity
...

@Ocramius
Copy link
Member

@hell0w0rd then I suppose it's fine to replace those also in the docs :)

@nkt
Copy link
Author

nkt commented May 19, 2013

@Ocramius docs added

@nkt
Copy link
Author

nkt commented May 22, 2013

@beberlei ping

beberlei added a commit that referenced this pull request May 26, 2013
@beberlei beberlei merged commit e8b3598 into doctrine:master May 26, 2013
@nkt nkt deleted the namespace_base_commands_names branch May 26, 2013 20:54
@nkt nkt restored the namespace_base_commands_names branch May 26, 2013 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants