Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EntityRepository] Cleanup named native features #7095

Merged
merged 1 commit into from
Feb 25, 2018
Merged

[EntityRepository] Cleanup named native features #7095

merged 1 commit into from
Feb 25, 2018

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Feb 25, 2018 •
edited
Loading

Named DQL queries were already removed before, this PR removes named native queries as well before doing further changes to ER interface.

@beberlei beberlei changed the title [EntityRepository] Cleanup named native and add return type hints to ER [EntityRepository] Cleanup named native features Feb 25, 2018
@Ocramius Ocramius self-assigned this Feb 25, 2018
@Ocramius Ocramius added this to the 3.0 milestone Feb 25, 2018
Ocramius
Ocramius approved these changes Feb 25, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius merged commit d952c12 into master Feb 25, 2018
@Ocramius Ocramius deleted the EntityRepository3 branch February 25, 2018 23:13
Majkl578 added a commit to Majkl578/doctrine-orm that referenced this pull request Mar 4, 2018
@Majkl578
Remove dead code leftovers after doctrine#7095
2080f50
@Majkl578 Majkl578 mentioned this pull request Mar 4, 2018
Closed
Ocramius pushed a commit that referenced this pull request Mar 4, 2018
@Majkl578 @Ocramius
Remove dead code leftovers after #7095
a0cd82b
Ocramius added a commit that referenced this pull request Mar 4, 2018
@Ocramius
#7113 #7095 removed unused imports
9f8af8e
Ocramius added a commit that referenced this pull request Mar 4, 2018
@Ocramius
Merge branch 'fix/#7113-#7095-remove-dead-code-leftovers-in-classmeta…
ec508af 
…data'

Close #7113
maglnet pushed a commit to maglnet/doctrine2 that referenced this pull request Oct 10, 2018
@Majkl578 @maglnet
Remove dead code leftovers after doctrine#7095
8181642
maglnet pushed a commit to maglnet/doctrine2 that referenced this pull request Oct 10, 2018
@Ocramius @maglnet
doctrine#7113 doctrine#7095 removed unused imports
930d74a
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
This was referenced Oct 8, 2022
Merged
Merged
@soullivaneuh soullivaneuh mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@guilhermeblanco guilhermeblanco Awaiting requested review from guilhermeblanco

Assignees

@Ocramius Ocramius

Labels
BC Break Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beberlei @Ocramius @greg0ire