Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Blacklist" with "Banlist" in join example #8175

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

albe
Copy link
Contributor

@albe albe commented Jun 7, 2020

Resolves #8173

greg0ire
greg0ire previously approved these changes Jun 7, 2020
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albe Thank you for the PR. Can you please target the 2.7 branch for this? I'd like to have this in the currently supported versions too.

Example how to change your base branch:
https://makandracards.com/makandra/10173-git-how-to-rebase-your-feature-branch-from-one-branch-to-another

@SenseException SenseException changed the base branch from master to 2.7 June 7, 2020 14:35
@SenseException SenseException dismissed greg0ire’s stale review June 7, 2020 14:35

The base branch was changed.

@greg0ire
Copy link
Member

greg0ire commented Jun 7, 2020

@SenseException there is another PR for 2.7 already, but I thought this one was worth having too, since there are a lot more changes.

@albe
Copy link
Contributor Author

albe commented Jun 7, 2020

Yep, see #8174 - sorry, should have linked the two PRs in the first place :/

@albe albe changed the base branch from 2.7 to master June 7, 2020 20:18
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then #8174 will also cover the 2.8 branch. Thank you @albe

@greg0ire greg0ire merged commit 2a98a98 into doctrine:master Jun 9, 2020
@greg0ire
Copy link
Member

greg0ire commented Jun 9, 2020

Thanks @albe!

@albe albe deleted the patch-2 branch June 9, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace documentation example of "Blacklist" join query
3 participants