Added getHash method in SQLFilter to avoid caching the filtered queries #8393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
requested changes
Dec 19, 2020
| $hash = get_class($this).$parameterCount; | ||
| foreach ($this->parameters as $name => $param) { | ||
| if (is_object($param['value'])) { | ||
| $valueHash = spl_object_hash($param['value']); |
There was a problem hiding this comment.
spl_object_hash is not reliable within and across requests. You need to serialize the parameter. the API of setParameter only allows stirngs anyways, it is not enforced though. But that should allow us to do this.
There was a problem hiding this comment.
How about changing this method to
final public function getHash()
{
return self::class.$this;
}I don't think the serialize() will have a big performance impact here.
| @@ -95,6 +95,17 @@ public function testGetFilter() : void | |||
|
|
|||
| self::assertInstanceOf(MyFilter::class, $filterCollection->getFilter(self::TEST_FILTER)); | |||
| } | |||
|
|
|||
| public function testGetHash() | |||
There was a problem hiding this comment.
Please also add an object based parameter and see serialize.
alecszaharia
added a commit
to bagrinsergiu/doctrine-orm
that referenced
this pull request
Apr 2, 2021
alecszaharia
added a commit
to bagrinsergiu/doctrine-orm
that referenced
this pull request
Apr 5, 2021
alecszaharia
added a commit
to bagrinsergiu/doctrine-orm
that referenced
this pull request
Apr 20, 2021
alecszaharia
added a commit
to bagrinsergiu/doctrine-orm
that referenced
this pull request
Apr 20, 2021
alecszaharia
added a commit
to bagrinsergiu/doctrine-orm
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a new final method getHash on SQLFilter that generates a hash based on the called class name and all the parameters. Also the FilterCollection::getHash() was modified to use the getHash method from SQLFilter.
This is implemented acording to @beberlei's recomandation see the discussion bellow.
#3955 (comment)