-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDC-2332: Ensure managed entities are always tracked by UOW #8994
Conversation
47c1b24
to
5f50737
Compare
|
Thanks, fixed all cs |
@greg0ire Friendly ping |
Any updates on this ? |
Rebased on |
I am skeptical. Can you explain the test a little better via comments? Its doing s lot, not sure where exactly and what fails. Is the merge necessary to cause this? |
481e12e
to
97f9e26
Compare
Rebased on This same test |
just in case it helps: A long time ago, I also made a failing test case for this issue: #843. Not sure if it is more understandable, but just wanted to mention it if someone is looking for a different approach |
@@ -1541,6 +1551,8 @@ public function addToIdentityMap($entity) | |||
$idHash = implode(' ', $identifier); | |||
$className = $classMetadata->rootEntityName; | |||
|
|||
$this->oidMap[$oid] = $entity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of saving the whole document, just save a reference to it. This will also stop it from being garbage collected and uses much less memory
$this->oidMap[$oid] = &$entity;
@bigfoot90 maybe you want to join #10791 |
This is a rebase of MR #7407 on
2.9.x
branch.Fixes #3037