-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview table for events: Jump links #9131
Conversation
Well, the answer to what I said at doctrine#9039 (comment) > I'd like to see if this does come out nicely on the web page... ... is clearly NO ;-) Anyway, let's continue and care about the layout later... Questions: 1: Is it OK to link them like so? => Then I'll do the others. 2: The order of the events differs between the table (=same as list) and the chapters further down. I think the chapters make more sense (starting with `prePersist`), so I'm going to change the table. 3: Suggestion for the next table column: **Can change current entity**
|
I'm done with the links, please merge. Remarks/questions: |
Did you mean in this PR? Should I wait with further review or will you introduce it in another PR? |
No! Please review and merge this as-is, then I'll continue in a new one. |
Thanks @ThomasLandauer 🌻 |
I got them wrong in doctrine#9131 ;-)
I got them wrong in #9131 ;-)
Well, the answer to what I said at #9039 (comment)
... is clearly NO ;-)
Anyway, let's continue and care about the layout later...
Questions:
1:
Is it OK to link them like so? => Then I'll do the others.
2:
The order of the events differs between the table (=same as list) and the chapters further down. I think the chapters make more sense (starting with
prePersist
), so I'm going to change the table.3:
Suggestion for the next table column: Can change current entity