Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 0 when there's no metadata to process #9147

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

wickedOne
Copy link
Contributor

fixes symfony command throwing a type error in the run method.

happens @ https://github.com/symfony/console/blob/5.3/Command/Command.php#L301

fixes symfony command throwing a type error in the run method
derrabus
derrabus previously approved these changes Oct 23, 2021
@derrabus derrabus enabled auto-merge (squash) October 23, 2021 09:23
@derrabus derrabus disabled auto-merge October 23, 2021 09:24
@derrabus derrabus added this to the 2.10.3 milestone Oct 23, 2021
@derrabus
Copy link
Member

Good catch, thank you. Let me update the PHPStan baseline for you.

@derrabus
Copy link
Member

Oh, I apparently cannot do that. Can you please run this on your branch and commit the phpstan-baseline.neon file?

./vendor/bin/phpstan --generate-baseline

@derrabus derrabus added the Bug label Oct 23, 2021
@wickedOne
Copy link
Contributor Author

done...

@derrabus derrabus enabled auto-merge (squash) October 23, 2021 09:35
@derrabus derrabus merged commit f2729b0 into doctrine:2.10.x Oct 23, 2021
@wickedOne wickedOne deleted the convert-return branch October 23, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants