Infer type from field instead of column

[armenio]

getTypeOfColumn() relies on getTypeOfField(), and does not suffer from
mismatching issues caused by quoting, because you cannot quote a field.
Since a field can be composite, that method returns an array, hence why we
need to select the first element.

Fixes #9109 caused by #9010

[armenio]

need labels: "Bug" and "Failing Test"

[greg0ire]

In attempt to resolve #9109

Please improve your commit message according to the contributing guide.

Specifically, the commit message should explain what did not work before exactly, and why it works now. Here is the commit message I would reverse-engineer after reading your PR:

Infer type from field instead of column

getTypeOfColumn() relies on getTypeOfField(), and does not suffer from
mismatching issues caused by quoting, because you cannot quote a field.
Since a field can be composite, that method returns an array, hence why we
need to select the first element.

Fixes #9109

[greg0ire]

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

1. git rebase -i origin/2.10.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
2. A window will show up with many lines, replace pick with fixup on every line but the first one
3. For the first line, use r, so that you get a chance to re-use the commit message in Infer type from field instead of column #9153 (comment)
4. Close your editor, git should do its magic, and you should end up with one commit
5. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

[armenio]

Commits are squashed

[greg0ire]

Please use git commit --amend to drop the In attempt to resolve #9109 part of your commit message.

[armenio]

done.

[greg0ire]

As a related but separate issue from the issue at hand, I think we should either document that the $columnName argument is supposed to be quoted if that's indeed the intended usage, or improve that method to make it work regardless of whether it is quoted or not.

[armenio]

Thank you very much for your effort @greg0ire

[greg0ire]

@armenio you're welcome! I notice there is an issue with PostgreSQL though, can you please look into it?

[armenio]

Fixed PgSQL error with changing strategy to "AUTO" in @GeneratedValue of PK's

[beberlei]

@greg0ire This should maybe even target a new 2.9.7 or? It was merged to 2.9.6 as far as i see breaking a core function.

[greg0ire]

@beberlei 2.9.x is no longer supported, and upgrading to 2.10.x does not seem like a huge deal so I would backport it iff someone complains they cannot upgrade. Otherwise, it's a good incentive to get people to upgrade IMO 🙂

[greg0ire]

Thanks @armenio !

[beberlei]

@greg0ire I guess another suggestion could be to downgrade to 2.9.4