Use equal to instead of equal of in assertSqlGeneration()
#9195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
equal-to-english
branch
2 times, most recently
from
c2b6628 to
95e1cd6
Compare
|
Restarting the build after the merge up |
|
🤔 🤔 🤔 Why are you contributing this to 3.0.x and not 2.10.x? |
simPod
force-pushed
the
equal-to-english
branch
from
95e1cd6 to
57aefa1
Compare
|
I had 3.0 checked out. changed. |
derrabus
approved these changes
Nov 20, 2021
|
I think the right order for this was switch branch, and then force push, Github CI looks confused… |
auto-merge was automatically disabled
November 20, 2021 20:07
Pull request was closed
derrabus
added a commit
that referenced
this pull request
Nov 28, 2021
* Adding Attributes code block (#9161) Just that there is some real-world example somewhere ;-) see #9020 (comment) * Use `equal to` instead of `equal of` in `assertSqlGeneration()` (#9195) * Add a psalm type for field mapping Field mapping have different definitions in property definition and method return. As suggested in issue and to avoid further desynchronization, a psalm type has been created. Fixes #9193 * Psalm 4.13.1, PHPStan 1.2.0 (#9204) Co-authored-by: Thomas Landauer <thomas@landauer.at> Co-authored-by: Simon Podlipsky <simon@podlipsky.net> Co-authored-by: Julien LARY <47776596+laryjulien@users.noreply.github.com> Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 29, 2021
* 2.11.x: Add missing deprecations for YAML metadata mapping (doctrine#9206) Drop support for DBAL 3.1 Psalm 4.13.1, PHPStan 1.2.0 (doctrine#9204) Add a psalm type for field mapping Use `equal to` instead of `equal of` in `assertSqlGeneration()` (doctrine#9195) Adding Attributes code block (doctrine#9161)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 29, 2021
* 2.11.x: Add missing deprecations for YAML metadata mapping (doctrine#9206) Drop support for DBAL 3.1 Psalm 4.13.1, PHPStan 1.2.0 (doctrine#9204) Add a psalm type for field mapping Use `equal to` instead of `equal of` in `assertSqlGeneration()` (doctrine#9195) Adding Attributes code block (doctrine#9161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.