Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the doctrine binary #9661

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Apr 15, 2022

Follows doctrine/dbal#5084
Part of #7498

This PR deprecates the vendor/bin/doctrine binary.

Today, the ORM is usually configured by some kind of framework integration, like DoctrineBundle. In those cases, the existence of a vendor/bin/doctrine binary is highly confusing. When invoking it, the binary will simply not work and tell the user to create some configuration file. This is misleading because the integration package will most likely take care of boostrapping the entity manager and sets up the commands properly. In the context of a full-stack Symfony application, DoctrineBundle would merge the ORM's commands into the applications bin/console script.

Of course, there's still the possibility of using the ORM standalone. For this case, I have documented how to set up the a bin/doctrine binary. Setting up that binary is not really more complicated than setting up the cli-config.php script that would be required to make the vendor/bin/doctrine script work.

Moreover, it puts the developer in control over how the console is bootstrapped for their application. They can find out more easily how to set up the console for multiple entity managers or how to add more commands to it.

@derrabus derrabus added this to the 2.12.0 milestone Apr 15, 2022
@derrabus derrabus force-pushed the deprecate/doctrine-binary branch 3 times, most recently from 2867d9a to 084de33 Compare April 15, 2022 13:24
@derrabus derrabus force-pushed the deprecate/doctrine-binary branch from 084de33 to bc3ebe7 Compare April 15, 2022 13:35
bin/doctrine-pear.php Outdated Show resolved Hide resolved
docs/en/reference/tools.rst Outdated Show resolved Hide resolved
docs/en/reference/tools.rst Outdated Show resolved Hide resolved
@derrabus derrabus force-pushed the deprecate/doctrine-binary branch from bc3ebe7 to eaad81b Compare April 16, 2022 18:38
@derrabus derrabus force-pushed the deprecate/doctrine-binary branch from eaad81b to 193aa0e Compare April 19, 2022 09:02
@derrabus derrabus merged commit d550364 into doctrine:2.12.x Apr 19, 2022
@derrabus derrabus deleted the deprecate/doctrine-binary branch April 19, 2022 18:34
derrabus added a commit that referenced this pull request Apr 19, 2022
* 2.12.x:
  Deprecate the doctrine binary (#9661)
  ScalarColumnHydrator: prevent early-bail on falsy values (#9663)
  Fix enum hydration when fetching partial results (#9657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants