Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix change detection for non-scalar readonly properties #9998

Closed
wants to merge 2 commits into from
Closed

Fix change detection for non-scalar readonly properties #9998

wants to merge 2 commits into from

Commits on Aug 17, 2022

  1. Refactor ReflectionReadonlyPropertyTest for testing with different types

    @nCrazed
    nCrazed committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    b68dd4b View commit details
    Browse the repository at this point in the history

  2. Check readonly property equality via equals() method when it's available 

    This fixes a bug where non-scalar readonly properties (like Uuid) will
cause an "Attempting to change readonly property..." error despite the
underlying value not actually changing.

The implementation isn't for a specific object type like the ones provided by
symfony/uid (which is used in the new test cases), but instead relies on the
common convention of value objects defining an equals() method for correct
equality checking.
    @nCrazed
    nCrazed committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    481795a View commit details
    Browse the repository at this point in the history