Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Psalm 4.3.1 and use ramsey/composer-install #151

Merged
merged 4 commits into from
Dec 30, 2020
Merged

Upgrade to Psalm 4.3.1 and use ramsey/composer-install #151

merged 4 commits into from
Dec 30, 2020

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu force-pushed the ga_improvements branch 2 times, most recently from 4cb7f2f to ff16a0f Compare December 19, 2020 20:16
SenseException
SenseException approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if removing composer.lock in a patch version is fine.

@malarzm
Copy link
Member

malarzm commented Dec 22, 2020

Not 100% sure if removing composer.lock in a patch version is fine.

As long as our tests are working ok we'll be fine. The presence (or absence) is not important for others :)

@greg0ire greg0ire merged commit cb944a9 into doctrine:2.1.x Dec 30, 2020
@greg0ire
Copy link
Member

Thanks @franmomu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@franmomu @malarzm @greg0ire @SenseException