Support Doctrine Cache 2 #175
Conversation
|
🤔 any reason to target 1.4.x ? It's no longer maintained… the lowest supported branch is 2.1.x. |
derrabus
force-pushed
the
doctrine-cache-2
branch
2 times, most recently
from
8021c7c to
d12e714
Compare
|
Persistence 1 is still downloaded a lot: https://packagist.org/packages/doctrine/persistence/stats And since this is merely unblocking a dependency that is already compatible, I thought targeting v1 might be a good idea. But I just realized that 1.4 has never seen a release, so 1.3 would be the proper target. But if v1 is totally closed for changes, I can target 2.1 instead. |
|
Please do, people using v1 are apparently not worried about staying up-to-date enough to care about upgrading to cache v2 IMO. Also, as you can see, the pipeline is very outdated on that branch (and broken). |
derrabus
force-pushed
the
doctrine-cache-2
branch
from
d12e714 to
15e28c3
Compare
| $cache->save(ChildEntity::class . '$CLASSMETADATA', $metadata); | ||
|
|
||
| $this->cmf->setCacheDriver($cache); | ||
|
|
||
| self::assertSame($metadata, $this->cmf->getMetadataFor(ChildEntity::class)); | ||
| self::assertEquals($metadata, $this->cmf->getMetadataFor(ChildEntity::class)); |
There was a problem hiding this comment.
💡 Those tests were actually broken. A cache usually serialized/deserializes the given object, so you cannot expect to receive the very same instance you've inserted.
* Remove use of deprecated TestCase::at() method For that test it does not add value to check the order of calls. * Support Doctrine Cache 2 (#175) * Fix Psalm and PHPStan errors for Doctrine Cache 2 (#176) * Fix missing use statement * Fix invalid assertion Co-authored-by: Fran Moreno <franmomu@gmail.com> Co-authored-by: Alexander M. Turek <me@derrabus.de> Co-authored-by: Andreas Braun <git@alcaeus.org>
This library is already compatible with Doctrine Cache 2 because it only depends on the interfaces. For tests, I've added Symfony Cache because Doctrine Cache 2 does not provide any implementations.