Require PHP 8.4 #473
Merged
Require PHP 8.4 #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with other Doctrine projects. Note that I had to add a "covariant" keyword on the template definition of getReflectionClass() return type. That's because since PHP 8.4, ReflectionClass is considered invariant because of lazy objects. Lazy objects introduce new methods to ReflectionClass where the template appears in parameter position, for instance that is the case for isUninitializedLazyObject(). I do not understand why this wasn't an issue with ReflectionClass::isInstance(), which was introduced way earlier than that though. The solution I picked is to use "call-site variance", effectively saying that this is OK in this instance (but it might not be, I'm not sure). The alternative to adding this keyword would be to drop generic information entirely. See phpstan/phpstan#12459 for more details.
greg0ire
requested review from
GromNaN,
SenseException,
derrabus,
malarzm and
stof
GromNaN
reviewed
Nov 2, 2025
SenseException
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with other Doctrine projects. Note that I had to add a "covariant" keyword on the template definition of
getReflectionClass()return type. That's because since PHP 8.4,ReflectionClassis considered invariant because of lazy objects. Lazy objects introduce new methods toReflectionClasswhere the template appears in parameter position, for instance that is the case forisUninitializedLazyObject(). I do not understand why this wasn't an issue withReflectionClass::isInstance(), which was introduced way earlier than that though.The solution I picked is to use "call-site variance", effectively saying that this is OK in this instance (but it might not be, I'm not sure).
The alternative to adding this keyword would be to drop generic information entirely.
See phpstan/phpstan#12459 for more details.