[TASK] Introduce Multi-Level TocTrees #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that functions like str_starts_with can be used in PHP 7.4 as well
|
Fyi, I'll put this one on my list to review tomorrow. |
jwage
approved these changes
Feb 27, 2023
wouterj
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Nice work! Just some very minor comments.
I must admit that I can't 100% follow all logic, but the changes in test look correct to me so the logic must also be correct :)
I haven't been able to test this PR on the Symfony docs yet, as #251 had quite a big impact on our docs-builder package. I'm working on fixing 0.6 compatibility, but for now we can only run 0.5.
Toctrees display subpages of subpages if `maxdepth` is not set or greater then one. The number of levels to be displayed depends on `:maxdepth:`. Only the main document title is used if `:titlesonly:` is set.
|
Thank you @wouterj I committed your suggestions. |
|
@greg0ire can we merge this PR? |
|
Can and did! Thanks @linawolf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toctrees display subpages of subpages if
maxdepthis not set or greater then one. The number of levels to be displayed depends on:maxdepth:. Only the main document title is used if:titlesonly:is set.resolves #197