Cursor based tokenizer #48
Conversation
goetas
force-pushed
the
tokenizer
branch
3 times, most recently
from
2f95fc3 to
da33754
Compare
| if (isset($originalTokens[$indexedToken['originalIndex']-1]) && | ||
| ! $originalTokens[$indexedToken['originalIndex']-1]->isOfType(Token::TOKEN_TYPE_WHITESPACE)) { | ||
| $prevToken = $cursor->subCursor()->previous(); | ||
| if ($prevToken && ! $prevToken->isOfType(Token::TOKEN_TYPE_WHITESPACE)) { |
There was a problem hiding this comment.
I'm not requiring you do it, but how would you feel about implementing the null object pattern to avoid all these checks?
There was a problem hiding this comment.
hmm. not sure about that. to do so i will have to introduce a TokenInterface and also to use an instanceof check in the while, or add one more method in the Cursor class... do you have a suggestion on how to implement it?
There was a problem hiding this comment.
I would rather add a new type, and check it in most methods if needed (but isOfType would not need to change, for instance). value() would require throwing, so would withValue
There was a problem hiding this comment.
Ah drop it, this is probably just another bad design idea on my part 😓
|
I have marked the |
|
Please squash some of the commits together (for instance the one that removes the debugging variable) |
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
|
Thanks @goetas ! |
No description provided.