Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0.0.rc.0 broken #749

Closed
andrewcharnley opened this issue Apr 24, 2017 · 2 comments
Closed

4.0.0.rc.0 broken #749

andrewcharnley opened this issue Apr 24, 2017 · 2 comments
Assignees
@tmcw
Labels
bug

Comments

@andrewcharnley
Copy link

Having upgraded I now get...

    at Of.escape (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/escape.js:61:23)
    at Of.text (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/visitors/text.js:31:27)
    at Of.one [as visit] (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/macro/one.js:36:30)
    at Of.all (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/macro/all.js:28:27)
    at Of.strong (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/visitors/strong.js:31:24)
    at Of.one [as visit] (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/macro/one.js:36:30)
    at Of.all (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/macro/all.js:28:27)
    at Of.paragraph (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/visitors/paragraph.js:21:15)
    at Of.one [as visit] (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/macro/one.js:36:30)
    at Of.listItem (/home/osboxes/git/lerna-repo/packages/common-process-service-storage-awsS3/node_modules/remark-stringify/lib/visitors/list-item.js:58:26)```
@andrewcharnley
Copy link
Author

andrewcharnley commented Apr 24, 2017 •
edited
Loading

Ok more info, it's flow specific...

I'm importing types as

import type types from './lib/types';

(I'd use named exports but babel, or perhaps tcomb, is enforcing the use of .default)

I then access the types such as the following, which is what breaks documentation.js

fD:types.minimalFileDescriptor

@tmcw tmcw self-assigned this Apr 24, 2017
tmcw added a commit that referenced this issue Apr 24, 2017
@tmcw
fix(flow): Fix inference of Flow types with properties
8a15040 
Previously we naively thought that id.name would be a string for all types, which is not the case.
Instead, we use babel-generator to safely generate string representations of types.

Fixes #749
@tmcw tmcw mentioned this issue Apr 24, 2017
Merged
tmcw added a commit that referenced this issue Apr 24, 2017
@tmcw
fix(flow): Fix inference of Flow types with properties
7fdc5a0 
Previously we naively thought that id.name would be a string for all types, which is not the case.
Instead, we use babel-generator to safely generate string representations of types.

Fixes #749
@tmcw
Copy link
Member

tmcw commented Apr 24, 2017

Thanks for the bug report! I've isolated this issue to a flow type with a property in it. I can also replicate this issue in beta.19 so maybe you upgraded from something older than that?

I have a fix and an expanded test suite in the PR: #751

@tmcw tmcw added the bug label Apr 24, 2017
@tmcw tmcw closed this as completed in #751 Apr 24, 2017
tmcw added a commit that referenced this issue Apr 24, 2017
@tmcw
fix(flow): Fix inference of Flow types with properties (#751)
7c00acc 
Previously we naively thought that id.name would be a string for all types, which is not the case.
Instead, we use babel-generator to safely generate string representations of types.

Fixes #749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmcw tmcw

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmcw @andrewcharnley