Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-specific locale links to Mozilla docs #964

Closed
pdehaan opened this issue Dec 3, 2017 · 3 comments
Closed

Add non-specific locale links to Mozilla docs #964

pdehaan opened this issue Dec 3, 2017 · 3 comments

Comments

@pdehaan
Copy link

pdehaan commented Dec 3, 2017

It seems like the data types always return MDN links (yay!), but MDN is pretty awesome at inferring the user's locale and serving up the best solution automatically, so it'd be nice if we could drop the /en-US/ bit and let MDN handle it.

### getTelemetryId

Returns **[string](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String)** the telemetry client ID

I tried searching the codebase, but couldn't find where/how we were generating those URLs.


$(npm bin)/documentation --version # 5.3.3
$(npm bin)/documentation build 'src/**' -f md --parse-extension=jsm -o docs/api.md
@tmcw
Copy link
Member

tmcw commented Dec 3, 2017

Sure! The links to builtins are handled by the globals-docs module, and in the globals-docs.json file.

@pdehaan
Copy link
Author

pdehaan commented Dec 4, 2017

You've been served! documentationjs/globals-docs#4

tmcw added a commit that referenced this issue Dec 12, 2017
This allows the Mozilla Developer Network to infer the user language.

Fix #964
@tmcw tmcw closed this as completed in #973 Dec 12, 2017
tmcw added a commit that referenced this issue Dec 12, 2017
This allows the Mozilla Developer Network to infer the user language.

Fix #964
@tmcw
Copy link
Member

tmcw commented Dec 12, 2017

Included in 5.3.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants