Skip to content

Conversation

@NumminorihSF
Copy link
Contributor

This PR resolves #1121.
Improve inferMembership to allow to use next code:

/**
 * @memberof BigFeature
 */
class MyClass {
  /** method */
  method() {}
}

Before this improvement, we have method inside
global.MyClass instead of global.BigFeature.MyClass

Improve inferMembership to allow to use next code:
```js
/**
 * @memberof BigFeature
 */
class MyClass {
  method() {}
}
```
Before this improvement, we have `method` inside
 `global.MyClass` instead of `global.BigFeature.MyClass`
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 85.612% when pulling 5a504a2 on NumminorihSF:fix/infer-membership-for-es6-classes into fb37789 on documentationjs:master.

@coveralls
Copy link

coveralls commented Aug 17, 2018

Coverage Status

Coverage increased (+0.1%) to 86.004% when pulling 3059f0b on NumminorihSF:fix/infer-membership-for-es6-classes into fb37789 on documentationjs:master.

@tmcw
Copy link
Member

tmcw commented Aug 17, 2018

Looks good, mind implementing a testcase to make sure that this doesn't regress?

@NumminorihSF
Copy link
Contributor Author

I'll try to implement a testcase it a bit later.

@NumminorihSF
Copy link
Contributor Author

@tmcw done

@tmcw tmcw merged commit 40b1783 into documentationjs:master Aug 23, 2018
@tmcw
Copy link
Member

tmcw commented Aug 23, 2018

👍 Thanks! Published in 8.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong membership infering for es6 classes' methods

3 participants