Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update highlight.js to the version 10. #1348

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Update highlight.js to the version 10. #1348

merged 1 commit into from
Jan 9, 2021

Conversation

francois2metz
Copy link
Contributor

Fix #1346

tmcw
tmcw approved these changes Jan 9, 2021
View reviewed changes
Copy link
Member

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@tmcw tmcw merged commit d775612 into documentationjs:master Jan 9, 2021
@francois2metz francois2metz deleted the update-highlightjs branch January 9, 2021 18:36
@omnidan
Copy link

omnidan commented Jan 19, 2021

@tmcw can you please make a patch release with this new version? the currently used version of highlight.js has a security vulnerability, as mentioned in #1346. a release would be very appreciated 🙏

@tmcw
Copy link
Member

tmcw commented Jan 19, 2021

Yep. I do kind of bristle at these automatic security checks, because they absolutely never actually have highlighted a real exploitable but in this project. They're mostly just "crying wolf" and making people overestimate dependency risks.

This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcw tmcw tmcw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight.js 9 End of Life
3 participants
@francois2metz @omnidan @tmcw