Testing: Support defining options for fixture tests #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,18 @@ function makePOJO(ast) { | |||
| return JSON.parse(JSON.stringify(ast)); | |||
| } | |||
|
|
|||
| function readOptionsFromFile(file) { | |||
| var s = fs.readFileSync(file, 'utf-8'); | |||
| var lines = s.split(/\n/, 20); | |||
There was a problem hiding this comment.
didn't know that String.prototype.split had a second param. Cool! Learned something today
|
Timed out. 120s is not enough on CircleCi 😢 |
|
I think there's actually a bug in the tap integration - according to the current docs, options is the second param, not the third. If true, this explains a lot of our issues with tests timing out. I've got a branch with this fixed, pushing it in a moment and hopefully that makes tests stabler. |
tmcw
added a commit
that referenced
this pull request
Aug 18, 2016
tmcw
added a commit
that referenced
this pull request
Aug 18, 2016
This reads the fixture file and looks for ```js // Options: <JSON> ``` which it uses as the options for documentation.build and documentation.buildSync.
arv
force-pushed
the
test-fixture-pragma
branch
from
3e5b6b9
to
4b5086b
Compare
|
CircleCi now passes 🚀 |
|
💯 excellent, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads the fixture file and looks for
// Options: <JSON>which it uses as the options for documentation.build and
documentation.buildSync.