Skip to content

fix(extractors): Document export default value #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2016

Conversation

arv
Copy link
Contributor

@arv arv commented Dec 2, 2016

With --document-exported we used to only support

export default Declaration

and

export default IdentifierExpression

With this change we generate a comment for all default exports.

Fixes #543

With `--document-exported` we used to only support

```js
export default Declaration
```

and

```js
export default IdentifierExpression
```

With this change we generate a comment for all default exports.

Fixes documentationjs#543
@arv arv assigned tmcw Dec 2, 2016
@tmcw
Copy link
Member

tmcw commented Dec 3, 2016

👍 lgtm, not sure what's going on with eslint - this PR doesn't change the indentation of the files it's complaining about

@arv arv merged commit 363a108 into documentationjs:master Dec 3, 2016
@arv arv deleted the document-export-default branch December 3, 2016 17:30
@arv arv mentioned this pull request Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants