Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the split in HTML at 33/67% instead of calculating percentages #939

Merged
merged 1 commit into from
Oct 12, 2017
Merged

fix: Fix the split in HTML at 33/67% instead of calculating percentages #939

merged 1 commit into from
Oct 12, 2017

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Oct 12, 2017

Previously this was calculated so that the left page would expand to its natural size. That's not
really what we want, because the natural size could be as high as 100%.

Fixes #927

@tmcw
fix: Fix the split in HTML at 33/67% instead of calculating percentages
56b2d55 
Previously this was calculated so that the left page would expand to its natural size. That's not
really what we want, because the natural size could be as high as 100%.

Fixes #927
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 56b2d55 on simple-split into c43701b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 56b2d55 on simple-split into c43701b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 56b2d55 on simple-split into c43701b on master.

@tmcw tmcw merged commit e4781eb into master Oct 12, 2017
@tmcw tmcw deleted the simple-split branch October 12, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmcw @coveralls