Statistic Module added #243

kpkalwa · 2021-04-15T10:10:35Z

No description provided.

jgonggrijp

Thanks for carrying over your work from jashkenas/underscore#2920, @kpkalwa! We'll continue the review process here.

Let's start with ensuring that the copy is 100% faithful to your Underscore branch. I currently see one missing module: you didn't copy modules/sum.js yet.

modules/index.collections.statistics.js

modules/percentile.js

modules/standardError.js

modules/variance.js

test/collections.statistics.js

jgonggrijp

Alright, seems like you copied all your code over and even fixed some indentation that I missed before! Good work.

The next step is to remove the pre-existing modules that you copied from Underscore (_baseIteratee.js, extendOwn.js, etcetera, not your own additions) and to update the import paths in your own new modules so that original Underscore modules are imported from the underscore package instead of from the same directory. This will truly integrate your code in Underscore-contrib, which is a library designed to depend on Underscore as an external dependency.

There will be two more steps after this: (1) add documentation and (2) clean up version history so that the original Underscore modules don't take up any space in the repository. Let's take this one step at a time, though.

modules/mean.js

modules/median.js

modules/mode.js

modules/percentile.js

modules/statRange.js

modules/sum.js

modules/variance.js

jgonggrijp · 2021-04-16T12:51:01Z

modules/variance.js

+  if (typeof iteratee == 'number' && collection != null && typeof collection[0] != 'object') { 
+    iteratee = null;
+  }
+  iteratee = cb(iteratee, context);


Suggested change

iteratee = cb(iteratee, context);

iteratee = _.iteratee(iteratee, context);

jgonggrijp · 2021-04-22T20:02:37Z

Keep it up @kpkalwa, you're doing well!

You didn't follow up on the last change request in my most recent review. Please add another commit to complete it.

Next move is adding documentation. You can create a new docs/underscore.collections.statistics.md, following the same structure as in (for example) docs/underscore.array.builders.md. It's OK if it's a bit brief/rough for now.

kpkalwa · 2021-05-11T07:56:37Z

Can you review the changes

jgonggrijp · 2021-05-11T09:17:06Z

@kpkalwa I did, see here and here. You still have to follow up on those comments.

…into statistics

kpkalwa · 2021-10-21T05:54:22Z

Document for the statistics added @jgonggrijp

jgonggrijp

Thank you for resuming this work, @kpkalwa!

I see at least one loose end, but this is definitely moving in the right direction. The documentation looks promising.

jgonggrijp · 2021-10-21T14:28:00Z

docs/underscore.collections.statistics.md

+If the array has odd numbers then median is the middle element.
+
+If the array has even numbers then average of middle two numbers is the median value.


Odd/even number of numbers. For brevity and less confusion, though, I suggest "length".

Suggested change

If the array has odd numbers then median is the middle element.

If the array has even numbers then average of middle two numbers is the median value.

If the array has odd length then median is the middle element.

If the array has even length then average of middle two numbers is the median value.

jgonggrijp · 2021-10-21T14:28:43Z

docs/underscore.collections.statistics.md

+
+#### mean
+
+Signature: `_.mean(... arrays:Array ...)`


Is it really arrays, plural?

jgonggrijp · 2021-10-21T14:29:13Z

docs/underscore.collections.statistics.md

+
+Signature: `_.sum(... arrays:Array ...)`
+
+The `_.sum` function calculates the sum of the given arrays.


I presume it sums a single array.

Suggested change

The `_.sum` function calculates the sum of the given arrays.

The `_.sum` function calculates the sum of the given array.

jgonggrijp · 2021-10-21T14:30:07Z

docs/underscore.collections.statistics.md

+
+Signature: `_.variance(... arrays:Array ...)`
+
+The `_.variance` function return the variance of the numeric elements of the collection.


Perhaps add a link here to the Wikipedia entry that explains the variance. Likewise for the other statistical concepts that follow.

jgonggrijp · 2021-10-21T14:32:49Z

modules/variance.js

@@ -9,7 +9,7 @@ export default function variance(collection, iteratee, context) {
  if (typeof iteratee == 'number' && collection != null && typeof collection[0] != 'object') { 
    iteratee = null;
  }
-  iteratee = cb(iteratee, context);
+  iteratee = iteratee(iteratee, context);


This needs to be _.iteratee in order to work.

Suggested change

iteratee = iteratee(iteratee, context);

iteratee = _.iteratee(iteratee, context);

kpkalwa · 2021-10-22T04:18:13Z

The document and Function has been updated @jgonggrijp

jgonggrijp

Excellent! There is only one last thing left to do: remove the Underscore modules from the history of this branch. I'll show you how to achieve this below.

First, make a backup copy of your branch in case anything goes wrong:

git branch statistics-bak statistics

Now we're going to do an interactive rebase. The following command will open an editor:

git rebase -i master statistics

In the editor, you see all of your nine commits listed. On the second, third, fourth and fifth line, change the initial word "pick" into "fixup". This will effectively merge the first five commits into one, causing the Underscore modules that you copied and then removed again to disappear from history.

pick d7d95a2 Statistic Module added
fixup adcd925 Error Fixed
fixup 063e7bd Sum function dependency added and whitespaces issuse resolved
fixup f637c05 Issue in statistics test js fixed
fixup bdd4339 Underscore base package chnages
pick 2a76ba2 Docs added
pick c3aea80 Docs added and Changes made as suggested
pick 72a910b Changes made as suggested

Save your changes and close the editor. Git will now restructure your branch so it consists of four commits and starts from current master. You can check than the overall changes are still the same with the following command (should give no output):

git diff statistics-bak statistics

You can also review your new history in detail with the following command:

git log -p -4

If everything looks good to you, force-push the new version of your branch:

git push --force

You can now remove the backup of your branch:

git branch -D statistics-bak

Alternatively, if anything goes wrong, you can reset your statistics branch to what it was with the following commands:

git checkout statistics
git reset --hard statistics-bak

Bumps [ws](https://github.com/websockets/ws) from 7.3.1 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.3.1...7.4.6) Signed-off-by: dependabot[bot] <support@github.com>

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…ntrib into statistics

kpkalwa · 2021-10-25T04:03:34Z

Excellent! There is only one last thing left to do: remove the Underscore modules from the history of this branch. I'll show you how to achieve this below.

First, make a backup copy of your branch in case anything goes wrong:
git branch statistics-bak statistics
Now we're going to do an interactive rebase. The following command will open an editor:
git rebase -i master statistics
In the editor, you see all of your nine commits listed. On the second, third, fourth and fifth line, change the initial word "pick" into "fixup". This will effectively merge the first five commits into one, causing the Underscore modules that you copied and then removed again to disappear from history.
pick d7d95a2 Statistic Module added
fixup adcd925 Error Fixed
fixup 063e7bd Sum function dependency added and whitespaces issuse resolved
fixup f637c05 Issue in statistics test js fixed
fixup bdd4339 Underscore base package chnages
pick 2a76ba2 Docs added
pick c3aea80 Docs added and Changes made as suggested
pick 72a910b Changes made as suggested
Save your changes and close the editor. Git will now restructure your branch so it consists of four commits and starts from current master. You can check than the overall changes are still the same with the following command (should give no output):
git diff statistics-bak statistics
You can also review your new history in detail with the following command:
git log -p -4
If everything looks good to you, force-push the new version of your branch:
git push --force
You can now remove the backup of your branch:
git branch -D statistics-bak
Alternatively, if anything goes wrong, you can reset your statistics branch to what it was with the following commands:
git checkout statistics
git reset --hard statistics-bak

The git changes has been updated as per the request @jgonggrijp

jgonggrijp · 2021-10-25T10:58:11Z

@kpkalwa It seems something went wrong with the rebase. You're now contributing 15 commits rather than the 4 I expected and inspecting the first one confirms that the Underscore modules are still in the history.

Shall I do the rebase or do you want to give it another try? If I do it, the commits will still be credited to you.

kpkalwa · 2021-10-25T11:43:37Z

@kpkalwa It seems something went wrong with the rebase. You're now contributing 15 commits rather than the 4 I expected and inspecting the first one confirms that the Underscore modules are still in the history.

Shall I do the rebase or do you want to give it another try? If I do it, the commits will still be credited to you.

You can do the rebase @jgonggrijp

jgonggrijp · 2021-11-01T15:57:04Z

Replaced by #247.

in0068 added 2 commits April 15, 2021 15:39

Statistic Module added

d7d95a2

Error Fixed

adcd925

jgonggrijp added after modules This should be postponed until after modularization (temporary label, see #220) enhancement labels Apr 15, 2021

jgonggrijp requested changes Apr 15, 2021

View reviewed changes

in0068 added 2 commits April 16, 2021 10:11

Sum function dependency added and whitespaces issuse resolved

063e7bd

Issue in statistics test js fixed

f637c05

jgonggrijp requested changes Apr 16, 2021

View reviewed changes

Underscore base package chnages

bdd4339

jgonggrijp mentioned this pull request Oct 12, 2021

Feature Request: mean, median, sum jashkenas/underscore#2942

Closed

in0068 added 2 commits October 21, 2021 10:43

Merge branch 'master' of https://github.com/kpkalwa/underscore-contrib …

2239320

…into statistics

Docs added

2a76ba2

Docs added and Changes made as suggested

c3aea80

jgonggrijp requested changes Oct 21, 2021

View reviewed changes

Changes made as suggested

72a910b

jgonggrijp requested changes Oct 22, 2021

View reviewed changes

dependabot bot and others added 6 commits October 25, 2021 09:27

Bump ws from 7.3.1 to 7.4.6

acc73da

Bumps [ws](https://github.com/websockets/ws) from 7.3.1 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.3.1...7.4.6) Signed-off-by: dependabot[bot] <support@github.com>

Docs added

d83d48b

Docs added and Changes made as suggested

009a8cd

Changes made as suggested

b130a04

Merge branch 'statistics' of https://github.com/kpkalwa/underscore-co…

9962331

…ntrib into statistics

jgonggrijp mentioned this pull request Nov 1, 2021

Statistics #247

Open

jgonggrijp closed this Nov 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Statistic Module added #243

Statistic Module added #243

kpkalwa commented Apr 15, 2021

jgonggrijp left a comment

jgonggrijp left a comment

jgonggrijp Apr 16, 2021

jgonggrijp commented Apr 22, 2021

kpkalwa commented May 11, 2021

jgonggrijp commented May 11, 2021

kpkalwa commented Oct 21, 2021

jgonggrijp left a comment

jgonggrijp Oct 21, 2021

jgonggrijp Oct 21, 2021

jgonggrijp Oct 21, 2021

jgonggrijp Oct 21, 2021

jgonggrijp Oct 21, 2021

kpkalwa commented Oct 22, 2021

jgonggrijp left a comment

kpkalwa commented Oct 25, 2021

jgonggrijp commented Oct 25, 2021

kpkalwa commented Oct 25, 2021

jgonggrijp commented Nov 1, 2021

	iteratee = cb(iteratee, context);
	iteratee = _.iteratee(iteratee, context);

		If the array has odd numbers then median is the middle element.

		If the array has even numbers then average of middle two numbers is the median value.


		Signature: `_.sum(... arrays:Array ...)`

		The `_.sum` function calculates the sum of the given arrays.


		Signature: `_.variance(... arrays:Array ...)`

		The `_.variance` function return the variance of the numeric elements of the collection.

	iteratee = iteratee(iteratee, context);
	iteratee = _.iteratee(iteratee, context);

Statistic Module added #243

Statistic Module added #243

Conversation

kpkalwa commented Apr 15, 2021

jgonggrijp left a comment

Choose a reason for hiding this comment

jgonggrijp left a comment

Choose a reason for hiding this comment

jgonggrijp Apr 16, 2021

Choose a reason for hiding this comment

jgonggrijp commented Apr 22, 2021

kpkalwa commented May 11, 2021

jgonggrijp commented May 11, 2021

kpkalwa commented Oct 21, 2021

jgonggrijp left a comment

Choose a reason for hiding this comment

jgonggrijp Oct 21, 2021

Choose a reason for hiding this comment

jgonggrijp Oct 21, 2021

Choose a reason for hiding this comment

jgonggrijp Oct 21, 2021

Choose a reason for hiding this comment

jgonggrijp Oct 21, 2021

Choose a reason for hiding this comment

jgonggrijp Oct 21, 2021

Choose a reason for hiding this comment

kpkalwa commented Oct 22, 2021

jgonggrijp left a comment

Choose a reason for hiding this comment

kpkalwa commented Oct 25, 2021

jgonggrijp commented Oct 25, 2021

kpkalwa commented Oct 25, 2021

jgonggrijp commented Nov 1, 2021